mdbartos/pipedream

Bug related to multiple pumps

mdbartos opened this issue · 0 comments

mdbartos commented

Using multiple pumps causes indexing error.

Problem 1:

The following lines in numba_pump_flow_coefficients:

pipedream/pipedream_solver/nsuperlink.py

Lines 2719 to 2720 in 7b6fadb

_dHp[_dHp > _dHp_max] = _dHp_max
_dHp[_dHp < _dHp_min] = _dHp_min

Should be:

    _dHp[_dHp > _dHp_max] = _dHp_max[_dHp > _dHp_max]
    _dHp[_dHp < _dHp_min] = _dHp_min[_dHp < _dHp_min]

Problem 2:

The following lines in numba_solve_pump_flows:

pipedream/pipedream_solver/nsuperlink.py

Lines 2751 to 2752 in 7b6fadb

_dHp[_dHp > _dHp_max] = _dHp_max
_dHp[_dHp < _dHp_min] = _dHp_min

Should be:

    _dHp[_dHp > _dHp_max] = _dHp_max[_dHp > _dHp_max]
    _dHp[_dHp < _dHp_min] = _dHp_min[_dHp < _dHp_min]