Grpc API change request (missing field/werid info)

[KAIYOHUGO]

Announcement List API provide sort by CREATE_DATE and PUBLIC

mdoj/grpc/proto/backend.proto

Lines 360 to 361 in f4ee034

	SORT_CREATE_DATE = 1;
	SORT_PUBLIC = 2;

But the response didn't provide such info (CREATE_DATE and PUBLIC)

mdoj/grpc/proto/backend.proto

Lines 298 to 302 in f4ee034

	message AnnouncementInfo {
	required int32 id = 1;
	required string title = 2;
	required google.protobuf.Timestamp update_date = 3;
	}

So I think we should add such info into AnnouncementInfo or remove it from sort.

[Eason0729]

Adding such info would be appropriate.

[Eason0729]

Can you also provide a list of similar issue(missing fields), so I could correct it in one pull request.

[KAIYOHUGO]

List User API have a similar issue

mdoj/grpc/proto/backend.proto

Lines 799 to 800 in f4ee034

	service User {
	rpc List(ListUserRequest) returns (ListUserResponse);

It provide SORT_CREATE_DATE

mdoj/grpc/proto/backend.proto

Lines 777 to 780 in f4ee034

	enum Sort {
	SORT_CREATE_DATE = 0;
	SORT_SCORE = 1;
	}

But response do not provide

mdoj/grpc/proto/backend.proto

Lines 719 to 723 in f4ee034

	message UserInfo {
	required string username = 1;
	required uint64 score = 4;
	required int32 id = 3;
	}

[KAIYOHUGO]

List Contest API have a similar issue

mdoj/grpc/proto/backend.proto

Lines 703 to 704 in f4ee034

	service Contest {
	rpc List(ListContestRequest) returns (ListContestResponse);

It provide SORT_CREATE_DATE/SORT_UPDATE_DATE/SORT_PUBLIC

mdoj/grpc/proto/backend.proto

Lines 669 to 675 in f4ee034

	enum Sort {
	SORT_CREATE_DATE = 0;
	SORT_UPDATE_DATE = 1;
	SORT_BEGIN = 2;
	SORT_END = 3;
	SORT_PUBLIC = 4;
	}

But response do not provide, we should add such field or remove it from sort.

mdoj/grpc/proto/backend.proto

Lines 588 to 594 in f4ee034

	message ContestInfo {
	required int32 id = 1;
	required string title = 2;
	optional google.protobuf.Timestamp begin = 4;
	optional google.protobuf.Timestamp end = 5;
	required bool need_password = 6;
	}

[KAIYOHUGO]

The following message types has not be use. Consider remove them or provide such API

mdoj/grpc/proto/backend.proto

Lines 648 to 651 in f4ee034

	message UserRank {
	required int32 user_id = 1;
	required uint32 score = 2;
	}

mdoj/grpc/proto/backend.proto

Lines 653 to 657 in f4ee034

	message ListRankResponse {
	repeated UserRank list = 1;
	required string paginator = 2;
	required uint64 remain = 3;
	}

mdoj/grpc/proto/backend.proto

Line 693 in f4ee034

// message Users { repeated UserRank list = 1; }

[KAIYOHUGO]

List Problem API have a similar issue

mdoj/grpc/proto/backend.proto

Lines 214 to 215 in f4ee034

	service Problem {
	rpc List(ListProblemRequest) returns (ListProblemResponse);

It provide SORT_CREATE_DATE/SORT_UPDATE_DATE/SORT_PUBLIC

mdoj/grpc/proto/backend.proto

Lines 173 to 181 in f4ee034

	enum Sort {
	SORT_UPDATE_DATE = 0;
	SORT_CREATE_DATE = 1;
	SORT_AC_RATE = 2;
	SORT_SUBMIT_COUNT = 3;
	SORT_DIFFICULTY = 4;
	SORT_ORDER = 5;
	SORT_PUBLIC = 6;
	}

But response do not provide, we should add such field or remove it from sort.

mdoj/grpc/proto/backend.proto

Lines 137 to 150 in f4ee034

	message ProblemInfo {
	required int32 id = 1;
	required string title = 2;
	required uint32 submit_count = 3;
	// 0 - 500 easy
	// 500 - 1000 easy+
	// 1000 - 1500 medium
	// 1500 - 2000 medium+
	// 2000 - 2500 hard
	// 2500 - 3000 hard+
	// 3000 - inf geek
	required uint32 difficulty = 5;
	required float ac_rate = 4;
	}

[Eason0729]

Okay, I would work on it tomorrow.(If lab meeting goes well)