mdempsky/unconvert

tests aren't checked

tamird opened this issue 7 years ago · 2 comments

tamird commented 7 years ago

Seems that the call to (*golang.org/x/tools/go/loader.Config).Import should be (*golang.org/x/tools/go/loader.Config).ImportWithTests instead.

dmitshur commented 7 years ago

If support for tests is added, it would be nice to make it a boolean flag that's default true, similar to other tools, e.g.:

https://github.com/dominikh/go-tools/blob/b0e79018b59e45680f7b4eee178fabe79ac5e794/lint/lintutil/util.go#L120

(/cc @dominikh FYI, link to your code.)

mdempsky commented 6 years ago

A -test flag seems reasonable to me.