mdempsky/unconvert

Is the project abandoned?

ldez opened this issue · 3 comments

ldez commented

Hello,

The project still uses the deprecated golang.org/x/tools/go/loader instead of golang.org/x/tools/go/analysis.

There are no new commits in two years, and no answer to issues.

https://github.com/golang/tools/blob/587a15310bddfc939d37cfaa8be8ea4c3808c3f1/go/loader/doc.go#L10-L11

I build tools primarily to address my own needs, and I publish them in case they're useful to others or inspire folks to build even better tools.

I wrote unconvert to help cleanup the Go runtime and toolchain source code after we translated it from C to Go. The result left us with a lot of unnecessary type conversions, but the large amount of GOOS/GOARCH-specific code made it difficult to notice which conversions were unnecessary under every combination. Hence why that's a core feature of unconvert.

And that cleanup was done back in early 2016: golang/go@def1e72, golang/go@a03bdc3, golang/go@1441f76

I don't intend to break unconvert, because I know some people still find it useful. But I haven't had a need for it in years, so I'm not especially motivated to put more effort into it.

ldez commented

Thank you for your answer.
if someone does a migration PR to golang.org/x/tools/go/analysis would you accept it?

Probably not. Not because I think that's a bad idea, but I don't want to be on the hook for continuing to maintain unconvert.

If you or someone think that would be a good idea, you have my blessing to fork the project. Or start a new one, and reuse any ideas/code from unconvert that you find useful.