mdn/bob

Interactive Example Search Box looks broken / not intended

glmvc opened this issue · 3 comments

glmvc commented

Summary

While I was focusing a line of code in a live example, I wanted to search something on the page (browser default shortcut [cmd] + f) and then suddenly such a box popped up (see screenshot below).
I don't know if this is intentional or maybe for a11y reasons, but it definitely looks broken.

I haven't thought of a solution or anything else, I first wanted to ask about this and what the status is. Could not find anything on this in the repo on the fly.

URL

All embedded live examples - for example:
https://developer.mozilla.org/en-US/docs/Web/CSS/text-transform

Reproduction steps

  1. Focus a code example, so enter "editing mode"
  2. Press shortcut for browser search
  3. Search box opens

Expected behavior

As I said above, I don't know the status of the search box and whether it should appear at all.
In any case, it does not look right, and I personally felt that this is something unintentional.

Actual behavior

The buttons and inputs (checkboxes) are overflowing.
It also don't look like they are styled in a way it would fit the docs.

Additionally, it was a bit unexpected and I wondered why my browser search wasn't working because I had scrolled down and didn't see what was happening....

Device

Laptop

Browser

Chrome

Browser version

Stable

Operating system

Mac OS

Screenshot

search-box

Anything else?

No response

Validations

Guess this is a CodeMirror thing. @queengooborg , wdyt?

Yeah, looks like CodeMirror has its own search system, so when focused on the code editor, it'll listen for ⌘F and display its own search. A little annoying for our intents.

glmvc commented

@wbamberg thanks for moving the issue to the right place.
What is the status here? @queengooborg (I don't want to be annoying, but I just stumbled across this issue again)
I'm willing to help as far as my knowledge goes (and permission for this repo?).