[Suggestion] 'Locale' values would be better to be managed as a type.
C17AN opened this issue · 1 comments
C17AN commented
Summary
The locale
properties used in the project are of the string
type, and it would be nice if they were managed more strictly with the Locale
type.
- AS-IS (Code Suggestion at
on-github.tsx
)
- TO-BE
Anything else?
First of all, I think this could be a breaking change, so I started by fixing one small type.
If there is a reason for using the string type considering future scalability, etc., you can reject this PR. :)
Or If you think this proposal is okay, I'll fix the parts that are considered to have less impact to the Locale
type.
Validations
- I have read the Community Participation Guidelines.
- I have verified that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- I have checked that this is a concrete bug. For Q&A open a GitHub Discussion.