mdolab/pygeo

Rename `addGeoDV` functions

ewu63 opened this issue · 2 comments

ewu63 commented

Type of issue

What types of issue is it?
Select the appropriate type(s) that describe this issue

  • Refactor

Description

I propose that we change some of the function names, which are unnecessarily verbose:

  • addGeoDVGlobal -> addGlobalDV
  • addGeoDVLocal -> addLocalDV
  • addGeoDVSectionLocal -> addSectionLocalDV
eirikurj commented

I think that is probably fine. What about
addGeoDVSectionLocal -> addLocalSectionDV

In the case we want to maintain backwards compatibility for some time we should create wrapper functions with deprecation warnings.

ewu63 commented

I think we should open this up to the rest of the group to make sure these names are logical. Agreed on the deprecation warning, which I explained here