Cache requests

Question

Cache requests

Closed this issue 4 years ago · 6 comments

We should cache requests to avoid spamming them when using survolBackgroundRequest

Answer 1 · 2020-10-04T17:56:33.000Z

Hey, I'm interested in taking this! :)

Answer 2 · 2020-10-04T18:00:19.000Z

@Coteh Apologies for my poor etiquette, I've already had a go at this with #48. If you have a better implementation or @mdolr has a different idea for caching, please feel free to take over and I'll remove my PR :)

Answer 3 · 2020-10-04T18:03:15.000Z

@Brett78 No problem. Just skimmed it and looks good to me. 👍

Answer 4 · 2020-10-04T21:26:05.000Z

@mdolr PR #48 has now been merged in which fixes this issue. Should this be closed now?

Answer 5 · 2020-10-04T21:27:01.000Z

oh yeah it should, thanks. Thought it would close automatically because it was referenced ahah

Answer 6 · 2020-10-04T21:59:40.000Z

I believe if you put either the word “Fixes” or “Closes” before the issue number reference in the PR, it will set up the issue to be automatically closed on merge. On Oct 4, 2020, at 5:27 PM, $m_dolr <notifications@github.com<mailto:notifications@github.com>> wrote: oh yeah it should, thanks. Thought it auto-closed because it was referenced ahah — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#44 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAY74PWDDFN5TYYKQ3PPMM3SJDSDDANCNFSM4SDZEK5Q>.