mdsecresearch/BurpSuiteSharpener

Deadlock in saving or loading settings

Closed this issue · 2 comments

irsdl commented

A deadlock and ultimately a UI freeze can occur when loading or saving preferences.
A timeout needs to be added to all synchronized methods.
The solution in https://stackoverflow.com/questions/17233038/how-to-implement-synchronous-method-timeouts-in-java looks ok but needs to be implemented and tested for a while.

irsdl commented

This should be remediated now but I keep it open just in case it happens again in the near future.

irsdl commented

The way settings are working is changing by use of the new version of https://github.com/CoreyD97/Burp-Montoya-Utilities. This issue needs to be opened again if it happens again.