meatballs/DjAxelrod

Change UI to allow multiple duplicate strategies to be selected for a tournament

Closed this issue · 11 comments

At the moment only one of each strategy may be selected for a new tournament.

Off-topic: is there a test version online somewhere?

@nealedj Yes - absolutely agree with the need to do this
@langner No - this isn't hosted anywhere yet. You need to run a local instance in order to see where we're up to. (It's not anywhere near ready to be made public yet)

👍 :)

Just played around with this, looks awesome 👍

Only minor thing is the number box doesn't seem to quite fit?

screenshot 2015-06-22 08 45 25

@meatballs this ok to go in?

This is now breaking the graphical output which can't cope with more than one player of the same strategy. I think that should become a part of #44 rather than stopping this from progressing.

The number box is displaying fine on Chrome and Safari as a simple text box, but on Firefox, it has the issue that @drvinceknight pointed out above

When creating the multiple players they could/should just have a label 'Cooperator_0', 'Cooperator_1' etc.. Is that for #44 or would that be a simple enough fix?

I'll have a crack at that now
done

Just a quick note - adding numbers to the player names makes life harder on the front-end - I need to then remove the number to check against list of cheaters. Is it necessary to differentiate between multiple players? It's easy enough to change the vis code in #44 to deal with multiple instances of the same name (as in, it's already done ;-))

@martinjc no, adding the numbers is not necessary. It was only done to ensure that the graph worked for this PR. If you can fix it in the graph itself, then it can go.

How about I create a branch for #44 , you submit a PR to that branch for the work you've done so far and then I make the changes to get rid of the numbering?

sounds great!