medaminedev66/javascript-capstone

Group capstone: set up our Kanban board

Closed this issue · 2 comments

Link

We are 2 members of this team:

  • Student A: Rida Arif
  • Student B: Amine Smahi

Required Changes ♻️ ⚠️ 🚦

Hi dear student,

Good job so far!
You still need to work on some issues to go to the next project, but you are almost there!

mario_ladders

Good points 👍

You used proper GitHub Flow ✔️
Your linter checks are all passing ✔️
Your PR messages are descriptive ✔️

Aspects to improve ♻️

  • When I click the URL to see the project in your description, it sends me to issues URL in place the project but copy-pasting the URL it works, please work on it. 🐶
  • It looks like the tasks are not assigned to anyone at this point, please, make sure the photo appears on each card to be sure it was assigned. Look at the example below:
    image

your project at this point:
image

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

Approved project! ✅ 🥳 🎈 🎉🎉🎉🎉🎉🎉🎉🎉

Hi there,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

InbornCandidHornet-size_restricted

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.