Error Handler for spider

Question

Error Handler for spider

gilles-yvetot opened this issue 8 years ago · 3 comments

I have defined an error handler in my ajax spider, it is correctly triggered when I have a 400 request but I would love to be able to call the done() methods from the error handler and I see that the error object returned contains methods such as done(), complete() but I cannot make it work.

The use case would be when you query an API, and you reach a threshold or there is no more data (404), you want to be able to complete the script and save the previously accumulated data.

Answer 1 · 2017-01-25T17:53:56.000Z

Forgot to mention: awesome job !

Answer 2 · 2017-01-26T13:50:54.000Z

Thanks @gilles-yvetot. There is already similar issues on the subject if I recall correclty. I completely understand the appeal of such feature but unfortunately I don't have much time lately to address this issue. I would gladly accept a PR about error handling for the ajaxSpider however.

Answer 3 · 2017-01-27T20:15:59.000Z

Actually, I am super busy too right now :( I found a workaround in the mean time but will work on it in a near future ;) Gilles Y.

…

On Thu, Jan 26, 2017 at 8:50 AM, Guillaume Plique ***@***.***> wrote: Thanks @gilles-yvetot <https://github.com/gilles-yvetot>. There is already similar issues on the subject if I recall correclty. I completely understand the appeal of such feature but unfortunately I don't have much time lately to address this issue. I would gladly accept a PR about error handling for the ajaxSpider however. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#258 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEZvTcqvExFzvbhhvJC28UYMMA49mcYvks5rWKTAgaJpZM4LtzBj> .