mehdi-fathi/eloquent-filter

WhereBetweenCondition fails if start or end is zero

elrasco opened this issue · 2 comments

elrasco commented

Describe the bug
In file eloquent-filter/src/QueryFilter/Detection/ConditionsDetect/WhereBetweenCondition.php the condition fails if start or end is zero

To Reproduce
Steps to reproduce the behavior:
Pass to method detect something like
array ( 'price' => array ( 'start' => 0, 'end' => 336, ) )

Expected behavior
detect returns WhereBetween::class

Actual behavior
detect return null

mehdi-fathi commented

@elrasco Thanks for the report. I fixed it. Please update the package to 2.3.8.

elrasco commented

@mehdi-fathi thank you very much. It works now. super fast.