meilisearch/integration-guides

Add Codecov for all repositories

Closed this issue · 6 comments

qdequele commented

Codecov is already used in MeiliSearch, it helps us to know if a PR add non-tested code. If it's the case, we don't accept the PR. It's easy to install, easy to configure. Don't hesitate to ping me if you need help.

  • Python
  • PHP
  • Ruby
  • JS
  • Rails
  • Symfony
  • Go
  • C#
  • Dart
  • Swift
  • Java
fharper commented

I love that!

  • 👀1
curquiza commented

@bidoubiwa? We need your approval/opinion so that I can try it on one repo

  • 👍1
bidoubiwa commented

Great!

curquiza commented

FYI, on the core team side, we removed the trigger of CodeCoverage to every PR since we felt it more like a spam rather than a real report.
We still can trigger CodeCoverage on the MeiliSearch repo, but manually, see our yml config: https://github.com/meilisearch/MeiliSearch/blob/main/.github/workflows/coverage.yml

Maybe a manual trigger (or a cron) would be better rather than a trigger on each PR.
WDYT?

  • 👍2
  • 🚀1
brunoocasali commented

I would love to see this implemented in all the SDKs. Because I believe this will help us gather quick information when a contributor provides a PR for us. But unfortunately, we will not have time to work on this for the next months. I'll appreciate it if people from the community do it :)

brunoocasali commented

All the issues were created in the correspondent repositories!