Add documentation on builder methods.
bidoubiwa opened this issue ยท 5 comments
Currently some builder methods across the code base do not have any documentation. See for example:
meilisearch-rust/src/search.rs
Lines 287 to 303 in 1e687c7
It would be better if each of these methods are explained and showcase an example. As for example here
meilisearch-rust/src/indexes.rs
Lines 1239 to 1279 in 1e687c7
๐๐ปโโ๏ธ
If this issue is available for the public to pick up, I'd like to take it ๐.
I have read your contribution guidelines, and have contributed similar work for projects like tabled and mirrord.
Hey @IsaacCloos, that would be awesome if you do :) ๐
We are not assigning to avoid blocking the PR in case the contributor does not make the PR after all, but it would be a very valuable addition
Sorry for the delay! I was just able to sit down with this, and now have some preliminary research I'd like to clarify.
The targets
Currently some builder methods across the code base do not have any documentation. See for example:
Here is the list I've assembled (having found three instances of #[allow(missing_docs)]
:
- TaskQuery (19 methods)
- Settings (11 methods)
- SearchQuery (21 methods)
If there are others you'd like to add, please let me know!
The template
It would be better if each of these methods are explained and showcase an example. As for example here
/// { concise description }
///
/// # Example
///
/// ```rust
/// { runnable, doc-friendly example }
/// ```
If you'd like to standardize any other aspects into this template before I take a stab at this issue, please let me know!
Your feedback is much appreciated ๐
If there are others you'd like to add, please let me know!
I don't see any other.
Your template answers all our needs :) Thanks a lot. I don't have anything to add or change.