Auto batcher drops messages and keep sending empty batch instead
gwik opened this issue · 1 comments
gwik commented
The auto batcher sends empty batches forever after it sent MAX_BATCH_SIZE bytes because the byte count is not reset when the auto batcher takes the buffer from the batcher.
See patch:
It seems we can't create pull request to this repo if we're not a contributor...
irevoire commented
Oh, it's crazy we missed that 😱
Thanks for noticing! I fixed it with your code and made you a co-author of the commit just so you appear in the contributors.
It seems we can't create pull request to this repo if we're not a contributor...
About that, I don't understand why, I checked the parameter of the repo again, and I can't see any limitation like that + I already merged the PRs of other external contributors like here and there