mekomsolutions/openmrs-module-initializer

Message Source should interpret messages.properties with no suffix as English

mogoodrich opened this issue · 3 comments

mogoodrich commented

In OpenMRS, the convention is for the "default" messages properties files (ie messages.properties) to be in English.

However, the Message Source service in Initializer is set to interpret these files as being in the system default locale.
This is problematic. For example, on a server where the OS default is set to Spanish, the "messages.properties" will be added as Spanish keys, potentially overriding any actual translations provided in "messages_es.properties".

Additionally, since English is, by convention generally the only language there is guaranteed to be a translation for, and because generally we prefer display text in some language rather than raw message code, we should provide English as the final fallback when translating.

mogoodrich commented

PR here: #213

mks-d commented

This was merged at e29810d

Thanks so much @mogoodrich!

  • 👍1