Options page doesn't load in production
Closed this issue · 5 comments
Version 2.0.0;
Options page refers to .snowpack directory which doesn't appear to exist in the extension.
Facts:
- Locally built package works fine.
- The zip which was uploaded via semantic release does contain the
.snowpackdirectory since Github release asset is identeical to published zip.
Next:
- Will do a fresh install to see if there's some strangeness.
- Will try with a directory without a dot prefix.
Removing and re-installing still had the same problem.
I found https://bugs.chromium.org/p/chromium/issues/detail?id=27840 and https://bugs.chromium.org/p/chromium/issues/detail?id=23004 referencing pruning hidden folders as defined by a leading '.' so that's probably it.
It can't be tested with load as unpacked but it it can be reproduced by choosing 'Pack extension' option from extension management page.
Will rename to just snowpack and re-release and also post to the forums and maybe open an issue to warn when using files/folders with leading '.'. It's quite dangerous when development experience differs in fatal ways!
Good news is only options page used external modules and so impact will be somewhat limited.
🎉 This issue has been resolved in version 2.0.1 🎉
The release is available on:
Your semantic-release bot 📦🚀
Interestingly, https://crbug.com/792375 says only a select set of files/folders are ignored but this appears no longer true.
Here's the code: https://source.chromium.org/chromium/chromium/src/+/main:extensions/browser/extension_creator_filter.cc;drc=784a12a7296f539ea8b38d1ed18d87c77bc953c8;l=26
Gives another reference where they tweaked it: https://crbug.com/314360
I guess I just hadn't internalized that '.' means hidden so should not be used in production.