membraneframework/membrane_rtmp_plugin

MessageValidator API does not support stateful validators

dmorn opened this issue · 2 comments

dmorn commented

Given the API provided in https://github.com/membraneframework/membrane_rtmp_plugin/blob/master/lib/membrane_rtmp_plugin/rtmp/source/message_validator.ex, it is not possible to design a stream validator that has a state, e.g. a pre-shared RTMP stream key that the server is going to accept. I would propose to redesign it as a Protocol!

dmorn commented

This is how it looks like: kim-company@1dc8317. I can make a PR if you think that this approach may suit developer's needs better.

Hey @dmorn, you can open a PR to this repo