The targetElement doesn't seem to be passed to callback

Question

The targetElement doesn't seem to be passed to callback

Closed this issue 8 years ago · 2 comments

Hi,

I am using the latest version of angular-intro.js and the below code print targetElement as undefined.

this.ngIntroService.onAfterChange((targetElement) => {
     console.log('onBeforeChange:', targetElement)
});

I have checked the source code and it seems the targetElement is not passed to callback:

function onAfterChange(cb) {
  return intro.onafterchange(function (targetElement) {
    if(angular.isFunction(cb)) cb(targetElement); --> I had to add `targetElement` to cb
  });
}

Also all others funtions onChange, onBeforeChange etc are not passing targetElement.

Answer 1 · 2017-03-16T10:59:42.000Z

thanks for notify
i'll check it

Answer 2 · 2017-03-16T13:43:55.000Z

i've updated the example as well

http://plnkr.co/edit/4JdONL?p=preview