[Idea] CI verification of fixup-mountpoints
Opened this issue · 2 comments
It's more than easy to make a small mistake in fixup-mountpoints
(forget the trailing ;;
, for instance). Thus I'd suggest using some CI service [1] [2] to validate its correctness using shellcheck. [3] There's an official Docker image for shellcheck CI [4]
Similarly, pylint could be used to verify assert-device
(please keep in mind that pylint is sometimes overzealous). Still, the main concern is fixup-mountpoints
, because it's the one most PRs target.
[1] https://github.com/ligurio/Continuous-Integration-services/blob/master/continuous-integration-services-list.md
[2] https://github.com/marketplace/category/continuous-integration
[3] https://github.com/koalaman/shellcheck
[4] https://hub.docker.com/r/koalaman/shellcheck/
Thanks for these useful insights, I've briefly checked it out, but a couple of those I tried require an account to be registered in 3rd party websites, would you know a shellcheck CI working more out-of-the-boxy? :)
Shellcheck itself doesn't provide any CI service AFAIK. It's just a Haskell program. GitLab provides an integrated CI service for your repo but GitHub doesn't.
On GitHub you have to register with your GitHub account for a third-party CI service which integrates with GitHub. If the project is public, you could possibly use another account.