misconfigured eslint in travis ci
Closed this issue · 5 comments
s3341458 commented
currently:
./node_modules/eslint/bin/eslint.js 'src/**.ts'
suppose to be:
./node_modules/eslint/bin/eslint.js 'src/*/**.ts'
notice this when I was working on #252
DanielCollins commented
why do you have to exclude src in the src folder?
s3341458 commented
sorry for bad ticket writing, my ticket description is wrong and confused.
so in short, eslint did not check all the ts files inside src/entities folder \o/, I was quite suprised about this as well.
DanielCollins commented
i see. eslint seems to defer to https://github.com/isaacs/node-glob
DanielCollins commented
./node_modules/eslint/bin/eslint.js 'src/**/*.ts' should also work
DanielCollins commented
ah, yes, ./node_modules/eslint/bin/eslint.js 'src/**/*.ts'
is important.
./node_modules/eslint/bin/eslint.js 'src/*/**.ts' skips files not in a sub directory