merchisdk/sdk

misconfigured eslint in travis ci

Closed this issue · 5 comments

currently:
./node_modules/eslint/bin/eslint.js 'src/**.ts'

suppose to be:
./node_modules/eslint/bin/eslint.js 'src/*/**.ts'

notice this when I was working on #252

why do you have to exclude src in the src folder?

sorry for bad ticket writing, my ticket description is wrong and confused.

so in short, eslint did not check all the ts files inside src/entities folder \o/, I was quite suprised about this as well.

i see. eslint seems to defer to https://github.com/isaacs/node-glob

./node_modules/eslint/bin/eslint.js 'src/**/*.ts' should also work

ah, yes, ./node_modules/eslint/bin/eslint.js 'src/**/*.ts' is important.

./node_modules/eslint/bin/eslint.js 'src/*/**.ts' skips files not in a sub directory