Erase method defect

Question

Erase method defect

Closed this issue 10 years ago · 6 comments

maxim-saplin commented 11 years ago

'Init' method, count is set to 1:
'count' : 1,
'Erase' method, count is set to 0:
d.count = 0;

but should be 1. Consequent calls (with callbacks) of 'Paint -> Erase -> Paint' didn't work for me, changed count to 1 in 'Erase' method and it worked.

Answer 1 · 2014-09-23T13:24:30.000Z

Nice catch, confirmed fix. Pull request?

Answer 2 · 2014-12-15T15:08:53.000Z

Hello.
I can't find this lines in current code. Where did you fix it?
Repaint doesn't work for me too.

Answer 3 · 2014-12-15T15:27:08.000Z

@decadence In the erase method, replace the following line:
$this.find('svg').empty();
with
$this.empty();
and you should be able to paint again and again. I let @camoconnell know about it.

Answer 4 · 2014-12-15T20:37:03.000Z

I've pushed a change addressing the erase defect. It cancels / resets raf, empties the svg and retains the jquery data object, ready for another paint. Trial it on index.html in the repo, by clicking on the window and watching output in your console. thanks!

Answer 5 · 2014-12-15T20:38:23.000Z

@decadence let me know if this has fixed your issue.

Answer 6 · 2014-12-16T12:48:03.000Z

@inorganik @camoconnell
Thanks for the response! It's ok now.