computing W_clamp_min
rimelcheikh opened this issue · 0 comments
rimelcheikh commented
Hello,
I'm a PhD student working on XAI. And I came across your paper so I decided to test the provided implementation, which I thank you for. The code is very clear and easy to understand !
While studying the code, I noticed the following:
In cce_utils.py, line 68, shouldn't W_clamp_min be computed as
- (W_clamp_min / (min_margins * concept_norms)).T
- instead of (W_clamp_min / (max_margins * concept_norms)).T ?
I'm saying this based on equation (6) provided in section 3.2 of your paper. Please correct me if I'm wrong or if I misunderstood something.
Thank you in advance!