Prevent MeshSync from restarting unnecessarily on initial deployment
leecalcote opened this issue · 5 comments
Current Behavior
When Meshery Operator deploys MeshSync, it takes two restarts of MeshSync before it will start running.
Desired Behavior
No restarts.
Contributor Guides and Resources
- 🛠 Meshery Build & Release Strategy
- 📚 Instructions for contributing to documentation
- 🎨 Wireframes and designs for Meshery UI in Figma
- 🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack
@leecalcote It is because it waits for the broker. If the broker isn't available then the binary exits, and pod is stuck in crashloopbackoff untill the broker is available.
@leecalcote It is because it waits for the broker. If the broker isn't available then the binary exits, and pod is stuck in crashloopbackoff untill the broker is available.
If we were to change this behaviour, we would also do the same thing. Use something like exponentialbackoff to keep retrying inside the binary when the NATS connection fails. Kubernetes replicaset controller does this for us by keep retrying to start the pod. So do we want to add code here?
No, we don't want to add code here. We want to use an existing capability of either kubebuilder or of Kubernetes to facilitate readiness, dependency, and boot order.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.