CI: The build test is not working and it should be fixed.
Aisuko opened this issue Β· 4 comments
Current Behavior
The current build checking step has a condition below
However, even though the PR was approved or the comment includes an LGTM. The CI is still not being triggered.
Expected Behavior
The CI can be triggered by LGTM/approved, or we can add requirements for it after codecov
and golangci-lint
were successful.
Screenshots/Logs
Environment
- Host OS: Mac Linux Windows
- Platform: Docker or Kubernetes
- Meshery Server Version: stable-v
- Meshery Client Version: stable-v
Contributor Guides and Resources
- π Meshery Build & Release Strategy
- π Instructions for contributing to documentation
- π¨ Wireframes and designs for Meshery UI in Figma
- ππΎππΌ Questions: Layer5 Discussion Forum and Layer5 Community Slack
Hey @Aisuko I'd like to work on this issue
@duckling69 thank you.
Hey @Aisuko i think i got what the issue was basically
github.event_name == 'pull_request' & github.event.pull_request.body were only looking at body of initial PR comment not for comments added afterwards so i used issue_comment to trigger it when comment is added after initial pr
also added need for build so it always run after codecov
and golint
has run
Hey @Aisuko i think i got what the issue was basically
github.event_name == 'pull_request' & github.event.pull_request.body were only looking at body of initial PR comment not for comments added afterwards so i used issue_comment to trigger it when comment is added after initial pr also added need for build so it always run after
codecov
andgolint
has run
Hi, @duckling69 thanks for your clarify.