`graphql` signature diverges with standard graphql-js's one
alexstrat opened this issue ยท 2 comments
alexstrat commented
The common signature of the function graphql
in reactive-graphql
differs from graphql-js
.
With graphql-js
the signature is roughly:
import { graphql } from 'graphql';
graphql(schema: GraphQLSchema, query: Source | string, context?: object)..
While with reactive-graphql
:
import graphql from 'reactive-graphql';
graphql(query: DocumentNode, schema: GraphQLSchema, context: object) ..
Note the differences:
- the default import vs the "named" import
query
andschema
arguments position are inverted- the type of
query
is a string (or Source) in standard implementation and transformed inDocumentNode
in the implementation while in reactive version it expects aDocumentNode
directly context
is optional
These differences are more or less minor, but wanted to know if they are intended or not, and thus if maintainer would be open to accepting a PR fixing this.
mesosphere-frontend-ci commented
๐ This issue has been resolved in version 3.0.0 ๐
The release is available on:
Your semantic-release bot ๐ฆ๐