Toot Status favorite/boost menu has neither obvious action nor visible response

[alexbbrown]

Describe the bug

Hold tapping the reply/boost/favorite buttons on a toot raises a menu which lists your alts

It's purpose, effect and state are unexplained

this bug is for suggestions to improve this

To Reproduce
Steps to reproduce the behavior:

1. With two accounts configured in app
2. With first account A selected in account menu
3. With second account B not selected
4. Go to a feed
5. Go to a toot
6. Tap hold favorite
7. A menu appears with the name of the account B
8. Tap it
9. The menu dismissed
10. Nothing else happens visibly
11. The favorite icon remains the same
12. Tap hold favorite again
13. The menu appears. Nothing visibly different about the menu

Expected behavior

The user should be able to understand

• what will happen when menu item is touched
• that it did happen after menu is touched
• Whether the action will favorite or unfavorite this time
• If this toot is already alt-favorited

but this is not clear to the user because:

• there's no verb in the menu title or item
• There's no visual feedback or animation
• There's no indication in status that it's boosted or favorited by alt after
• There's no indication in the menu that it's happened once already or that the next action will reverse it

suggestions:

• menu should list all accounts not just alts. This helps explain how it's different
• Menu should include current state of fave/boost for each row (or for reply? IF replied)
• Status should display that it is favorited by alt. Possibly using secondary color to distinguish primary account favorite
• Tapping menu should show animation of status bar changing in response. This will teach user what it does

Screenshots
In this image: did I favorite it already, or not?

(please complete the following information):

• Device: iPhone 12
• OS: iOS 16.1.1
• App Version: 1.6

Additional context
Add any other context about the problem here.

Delving into the source code I now understand what this UI does.

its authenticatedIdentitiesMenu which displays a list of your other identities.

when provided for favourite and boost, tapping the menu has the effect of favoriting or boosting using your alt. Or, if it's already invisibly favorited, then unfavoriting it again