metakirby5/yorha

Seen a problem in the button class and suggested improvement

sawarafael opened this issue · 1 comments

If you install this via npm, and use in a Angular Framework (after linking it to angular.json).

All classes work correctly and smoothly, however, when using the button, its hover breaks and reaches the color value of when the pointer reaches it to black, it goes to white and the content inside the element extends away from the box where expected to stay.

I had to insert all the class configuration into my css file of my angular component, just like that it worked, but it's not something I really wanted to do.

I suggest you implement an injection of the class directly into the HTML element, something like:

<button #yorha-button-text> "submit" </button>

or

<button class="yorha-button-text"> "submit" </button>

I believe that with this setup, problems like the one above will resolve themselves.

I hope this issue is of great help to the project!

Thanks for the suggestion! Pull requests are welcome :)