Uplift controller-runtime to v0.17.x
adilGhaffarDev opened this issue · 5 comments
adilGhaffarDev commented
What steps did you take and what happened:
[A clear and concise description on how to REPRODUCE the bug.]
Currently, uplifting the controller-runtime to v0.17.x is causing some issues in BMO. When we bump:
- One unit test starts failing:
TestStoreHostFirmwareSettingstest is failing with specinitial hfs resource with no schema
fail logs: https://prow.apps.test.metal3.io/view/s3/prow-logs/pr-logs/pull/metal3-io_baremetal-operator/1675/test/1780224740770713600
--- FAIL: TestStoreHostFirmwareSettings (0.00s)
--- FAIL: TestStoreHostFirmwareSettings/initial_hfs_resource_with_no_schema (0.00s)
hostfirmwaresettings_test.go:610:
Error Trace: /home/prow/go/src/github.com/metal3-io/baremetal-operator/controllers/metal3.io/hostfirmwaresettings_test.go:610
Error: Not equal:
expected: &v1alpha1.FirmwareSchema{TypeMeta:v1.TypeMeta{Kind:"FirmwareSchema", APIVersion:"metal3.io/v1alpha1"}, ObjectMeta:v1.ObjectMeta{Name:"schema-4bcc035f", GenerateName:"", Namespace:"myHostNamespace", SelfLink:"", UID:"", ResourceVersion:"1", Generation:0, CreationTimestamp:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), DeletionTimestamp:<nil>, DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference{v1.OwnerReference{APIVersion:"metal3.io/v1alpha1", Kind:"HostFirmwareSettings", Name:"myHostName", UID:"", Controller:(*bool)(nil), BlockOwnerDeletion:(*bool)(nil)}}, Finalizers:[]string(nil), ManagedFields:[]v1.ManagedFieldsEntry(nil)}, Spec:v1alpha1.FirmwareSchemaSpec{HardwareVendor:"", HardwareModel:"", Schema:map[string]v1alpha1.SettingSchema{"AssetTag":v1alpha1.SettingSchema{AttributeType:"String", AllowableValues:[]string(nil), LowerBound:(*int)(nil), UpperBound:(*int)(nil), MinLength:(*int)(0x2568c40), MaxLength:(*int)(0x24b2580), ReadOnly:(*bool)(nil), Unique:(*bool)(0x24b2300)}, "CustomPostMessage":v1alpha1.SettingSchema{AttributeType:"String", AllowableValues:[]string(nil), LowerBound:(*int)(nil), UpperBound:(*int)(nil), MinLength:(*int)(0x2568c40), MaxLength:(*int)(0x24b2580), ReadOnly:(*bool)(0x2568af3), Unique:(*bool)(0x2568af3)}, "L2Cache":v1alpha1.SettingSchema{AttributeType:"String", AllowableValues:[]string(nil), LowerBound:(*int)(nil), UpperBound:(*int)(nil), MinLength:(*int)(0x2568c40), MaxLength:(*int)(0x24b2580), ReadOnly:(*bool)(0x24b2300), Unique:(*bool)(nil)}, "NetworkBootRetryCount":v1alpha1.SettingSchema{AttributeType:"Integer", AllowableValues:[]string(nil), LowerBound:(*int)(0x2568c48), UpperBound:(*int)(0x24b2588), MinLength:(*int)(nil), MaxLength:(*int)(nil), ReadOnly:(*bool)(0x2568af3), Unique:(*bool)(nil)}, "ProcVirtualization":v1alpha1.SettingSchema{AttributeType:"Enumeration", AllowableValues:[]string{"Enabled", "Disabled"}, LowerBound:(*int)(nil), UpperBound:(*int)(nil), MinLength:(*int)(nil), MaxLength:(*int)(nil), ReadOnly:(*bool)(0x2568af3), Unique:(*bool)(nil)}, "SecureBoot":v1alpha1.SettingSchema{AttributeType:"Enumeration", AllowableValues:[]string{"Enabled", "Disabled"}, LowerBound:(*int)(nil), UpperBound:(*int)(nil), MinLength:(*int)(nil), MaxLength:(*int)(nil), ReadOnly:(*bool)(0x24b2300), Unique:(*bool)(nil)}}}}
actual : &v1alpha1.FirmwareSchema{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"schema-4bcc035f", GenerateName:"", Namespace:"myHostNamespace", SelfLink:"", UID:"", ResourceVersion:"1", Generation:0, CreationTimestamp:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), DeletionTimestamp:<nil>, DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference{v1.OwnerReference{APIVersion:"metal3.io/v1alpha1", Kind:"HostFirmwareSettings", Name:"myHostName", UID:"", Controller:(*bool)(nil), BlockOwnerDeletion:(*bool)(nil)}}, Finalizers:[]string(nil), ManagedFields:[]v1.ManagedFieldsEntry(nil)}, Spec:v1alpha1.FirmwareSchemaSpec{HardwareVendor:"", HardwareModel:"", Schema:map[string]v1alpha1.SettingSchema{"AssetTag":v1alpha1.SettingSchema{AttributeType:"String", AllowableValues:[]string(nil), LowerBound:(*int)(nil), UpperBound:(*int)(nil), MinLength:(*int)(0xc0004c0c60), MaxLength:(*int)(0xc0004c0c68), ReadOnly:(*bool)(nil), Unique:(*bool)(0xc0004c0c72)}, "CustomPostMessage":v1alpha1.SettingSchema{AttributeType:"String", AllowableValues:[]string(nil), LowerBound:(*int)(nil), UpperBound:(*int)(nil), MinLength:(*int)(0xc0004c0c88), MaxLength:(*int)(0xc0004c0c90), ReadOnly:(*bool)(0xc0004c0c9a), Unique:(*bool)(0xc0004c0c9b)}, "L2Cache":v1alpha1.SettingSchema{AttributeType:"String", AllowableValues:[]string(nil), LowerBound:(*int)(nil), UpperBound:(*int)(nil), MinLength:(*int)(0xc0004c0ca8), MaxLength:(*int)(0xc0004c0cb0), ReadOnly:(*bool)(0xc0004c0cba), Unique:(*bool)(nil)}, "NetworkBootRetryCount":v1alpha1.SettingSchema{AttributeType:"Integer", AllowableValues:[]string(nil), LowerBound:(*int)(0xc0004c0cd0), UpperBound:(*int)(0xc0004c0cd8), MinLength:(*int)(nil), MaxLength:(*int)(nil), ReadOnly:(*bool)(0xc0004c0ce2), Unique:(*bool)(nil)}, "ProcVirtualization":v1alpha1.SettingSchema{AttributeType:"Enumeration", AllowableValues:[]string{"Enabled", "Disabled"}, LowerBound:(*int)(nil), UpperBound:(*int)(nil), MinLength:(*int)(nil), MaxLength:(*int)(nil), ReadOnly:(*bool)(0xc0004c0d00), Unique:(*bool)(nil)}, "SecureBoot":v1alpha1.SettingSchema{AttributeType:"Enumeration", AllowableValues:[]string{"Enabled", "Disabled"}, LowerBound:(*int)(nil), UpperBound:(*int)(nil), MinLength:(*int)(nil), MaxLength:(*int)(nil), ReadOnly:(*bool)(0xc0004c0d20), Unique:(*bool)(nil)}}}}
Diff:
--- Expected
+++ Actual
@@ -2,4 +2,4 @@
TypeMeta: (v1.TypeMeta) {
- Kind: (string) (len=14) "FirmwareSchema",
- APIVersion: (string) (len=18) "metal3.io/v1alpha1"
+ Kind: (string) "",
+ APIVersion: (string) ""
},
Test: TestStoreHostFirmwareSettings/initial_hfs_resource_with_no_schema
FAIL
make generate manifestsFail logs: https://prow.apps.test.metal3.io/view/s3/prow-logs/pr-logs/pull/metal3-io_baremetal-operator/1675/generate/1780224740707799040
What did you expect to happen:
All tests should pass after bump.
/kind bug
adilGhaffarDev commented
/triage accepted
lekaf974 commented
Looks there is already a PR merge for this issue, could it be closed ?
tuminoid commented
Looks there is already a PR merge for this issue, could it be closed ?
Issues will auto close when PR is merged if mentioned in the PR description, until then they need to remain open.
Linked PR did not fix the issue, since there was problem bumping controller-runtime.
metal3-io-bot commented
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Rozzii commented
/remove-lifecycle stale
FYI @adilGhaffarDev this went to stale