metaplex-foundation/amman

New version breaks if you don't install ts-essentials globally

mccjul opened this issue · 3 comments

mccjul commented

on running newest version of amman cli you get

node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module 'ts-essentials'
Require stack:
- /home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/relay/rest-server.js
- /home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/relay/server.js
- /home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/validator/init-validator.js
- /home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/validator/index.js
- /home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/utils/config.js
- /home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/cli/commands/start.js
- /home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/cli/commands/index.js
- /home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/cli/amman.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/relay/rest-server.js:6:25)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/relay/rest-server.js',
    '/home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/relay/server.js',
    '/home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/validator/init-validator.js',
    '/home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/validator/index.js',
    '/home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/utils/config.js',
    '/home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/cli/commands/start.js',
    '/home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/cli/commands/index.js',
    '/home/beanbopper/.nvm/versions/node/v16.10.0/lib/node_modules/@metaplex-foundation/amman/dist/cli/amman.js'
  ]
}

This can be fixed by installing ts-essentials globally but I think this should be part of the package itself.

thlorenz commented

Thanks for reporting, I don't have ts-essentials installed globally so not sure why this is happening in your case.
Gonna investigate and push a patch with a fix ASAP.

  • 👍1
thlorenz commented

OK verified what's going on ts-essentials is declared as a devDep incorrectly.

  • 👍1
thlorenz commented

Fix went out as @metaplex-foundation/amman@0.11.1.
Again thanks for catching this and sorry for any inconvenience ..

  • 🎉1