#81 discussion follow-up and request for comments

Question

#81 discussion follow-up and request for comments

aqrln opened this issue 8 years ago · 8 comments

After some discussion with @belochub about #81 we came to conclusion that we don't actually need sent messages count in both handshake request and response, only received ones.

/cc @lundibundi @Gagnant @GYFK @lidaamber

Gagnant commented 8 years ago

LGTM

lundibundi commented 8 years ago

LGTM

aqrln commented 8 years ago

Refs: #35

Answer 1 · 2017-02-26T19:43:33.000Z

Ok with me, that was actually the question when i asked about them.

Answer 2 · 2017-02-26T19:54:19.000Z

@lundibundi thanks for the feedback and for noticing a redundancy in the specs we prepared.
@Gagnant we need you approval to do this since you're a member of Session WG too and we don't want to break the iOS client :)

Answer 3 · 2017-02-26T19:56:24.000Z

Also agree with the changes

Answer 4 · 2017-02-26T20:01:11.000Z

@Gagnant great.

Hence I propose to update the handshake format like this:

Request	Response
`{ handshake: [0, 'appName'], session: ['sessionId', receivedCount] }`	`{ handshake: [0], ok: receivedCount }`

Note the absence of square brackets around receivedCount in the second case. @belochub, @lundibundi, @Gagnant, does this LGTY?

Answer 5 · 2017-02-26T20:24:54.000Z

LGTM, can't wait to start using this feature.