metrumresearchgroup/TFLGenerator

Metworx v3 migration

dpolhamus opened this issue · 3 comments

dpolhamus commented

There are some issues.

  • There is an Hmisc conflict with the newer version of R, we're going to have to use a newer Hmisc. Hopefully this doesnt wreak too much havoc. Here is a pkg dir that seems to work, with updated Hmisc and dependencies.

  • It looks like R:::shiny broke the way we do.call tabsetPanel. Here's the error:

Warning: Error in build: Tabs should all be unnamed arguments, but some are named: TabConcvTime1, TabConcvTimeGroup1, TabOBSvPRED1, TabparamDist1, TabcovCat1, TabcovCon1, TabcorPairs1, TabQQplot1, TabGOF1, TabdistMult1, TabbarchartMult1, TabVPC1
Stack trace (innermost first):
80: build
79: buildTabset
78:
77: do.call
76: renderUI [/data/shiny-server/TFL generator/server.R#1317]
75: func
74: origRenderFunc
73: output$figuresTabset
1: runApp

It also looks like there is an "id" argument to tabsetPanel now too, I imagine we need to strip the names of the list of panels and pass them in as "id".

We can start billing work for this against the maintenance budget in August.

yonicd commented

we dont want to move to session$ns(), right?

dpolhamus commented

We can certainly try it, I think it's valid maintenance. I'd be pretty surprised if that fixes this issue though.

dpolhamus commented

Actually, let's not start with that. The more we change, the more we open ourselves up to a new round of validation. Let's try to see if we can get the minimal # of changes in to get it working again and then go from there, i.e., let's target the "unnamed argments" error that's coming through right now.