NameError possibly caused by binary commit

[GoogleCodeExporter]

Upon having added a bunch of files (include a binary) the post-commit hook
failed.
$ svn commit
Adding         modules/geoip
Adding         modules/geoip/files
Adding         modules/geoip/files/GeoIP.conf
Adding  (bin)  modules/geoip/files/GeoIP.dat
Adding         modules/geoip/manifests
Adding         modules/geoip/manifests/init.pp
Adding         modules/keepalived
Adding         modules/keepalived/files
Adding         modules/keepalived/manifests
Adding         modules/keepalived/manifests/init.pp
Adding         modules/mysql
Adding         modules/mysql/manifests
Adding         modules/mysql/manifests/client.pp
Adding         modules/mysql/manifests/init.pp
Adding         modules/mysql/manifests/server.pp
Adding         modules/mysql/templates
Adding         modules/mysql/templates/dotmy.cnf
Adding         modules/mysql/templates/my.cnf
Transmitting file data .........
Committed revision 444.

Warning: 'post-commit' hook failed with error output:


This is what appeared in the log....
/opt/svnspam/svn_post_commit_hook.rb:161:in `assert_next': undefined local
variable or method `lines' for #<LineReader:0x7ff530f1fe50> (NameError)
        from /opt/svnspam/svn_post_commit_hook.rb:187:in `read_added_diff'
        from /opt/svnspam/svn_post_commit_hook.rb:286:in `process_svnlook_diff'
        from /opt/svnspam/svn_post_commit_hook.rb:101:in `svnlook'
        from /opt/svnspam/svn_post_commit_hook.rb:55:in `safer_popen'
        from /opt/svnspam/svn_post_commit_hook.rb:51:in `popen'
        from /opt/svnspam/svn_post_commit_hook.rb:51:in `safer_popen'
        from /opt/svnspam/svn_post_commit_hook.rb:100:in `svnlook'
        from /opt/svnspam/svn_post_commit_hook.rb:280:in `process_svnlook_diff'
        from /opt/svnspam/svn_post_commit_hook.rb:305:in `process_commit'
        from /opt/svnspam/svn_post_commit_hook.rb:303:in `open'
        from /opt/svnspam/svn_post_commit_hook.rb:303:in `process_commit'
        from /opt/svnspam/svn_post_commit_hook.rb:313:in `main'
        from /opt/svnspam/svn_post_commit_hook.rb:319

Original issue reported on code.google.com by m...@foster.cc on 16 Jan 2009 at 3:23

[GoogleCodeExporter]

I've also noticed that commits with binary files ends up with no email at all.

Original comment by knitt...@gmail.com on 27 May 2009 at 2:57