mfridman/tparse

Tool fails, versions >= v0.10.0

georlav opened this issue · 2 comments

All versions >= v0.10.0 fail

Hello i am using your parser in some of my CIs and after your latest changes it fails with the following error.
When i use v0.9.0 everything works.

go test -race ./... -v -short -json --failfast | tparse -all -notests -dump

Error: ../../../go/pkg/mod/github.com/mfridman/tparse@v0.10.1/internal/app/table_failed.go:52:18: undefined: strings.Cut
Error: Process completed with exit code 2.

Sorry about that. The short of it is some flags were removed with the underlying implementation. The -dump flag is replaced with -follow. (more details here #58)

In order to make forward progress on the project I needed to refactor some bits, and -dump was never an ideal implementation because it was holding all the JSON events in memory.

The -follow flag is almost always what folks want. It "streams" or "follows" go test output as the tests are running without buffering that output.

Going to close this issue.

But I do want to emphasize that I take great care in breaking changes and avoid it at all costs. In this particular case those changes seemed warranted based on feedback and actual usage.