ContextSymbol.getModules() returns duplicated modules
ghsyeung opened this issue · 2 comments
ghsyeung commented
Since NgAnalyzedModules.ngModuleByPipeOrDirective returns a map, and getModules uses only the values. There are multiple references/clones of the same module metadata (like CommonModule) returned by getModules().
Looks like we need to de-dupe by type.reference.
mgechev commented
Do you have time for a quick PR? Otherwise, I can address this issue early next week.
ghsyeung commented
Yeah I'll put a test case and PR tomorrow.
…On Feb 18, 2017 7:50 PM, "Minko Gechev" ***@***.***> wrote:
Do you have time for a quick PR? Otherwise, I can address this issue early
next week.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABL4Mb4I7-djHApaoMFYtkh_pd7qoZrBks5rd7vugaJpZM4MEBzY>
.