Move statement-local warnings behind another flag

Question

Move statement-local warnings behind another flag

Closed this issue 5 years ago · 3 comments

So they can be disabled separately, as requested by Richard. fyi @Xazax-hun

Answer 1 · 2019-08-23T20:56:31.000Z

@Xazax-hun Would you be able to move the rest of our statement-local warnings behind that flag? I'm not exactly sure about the logic yet.
Would we need to sprinkle if(IsGslPtrInitWithGslTempOwner) around Diag(DiagLoc, diag::warn_ret_stack_addr_ref) and other diags?

Answer 2 · 2019-08-23T21:02:37.000Z

Yeah, unfortunately, they are not all behind the same flag, because there are some logic reused between all those warnings. I think I have something slightly different in mind.

Answer 3 · 2019-08-25T20:25:43.000Z

This is now partly implemented.