Consistently set FG and BG colors

Question

Consistently set FG and BG colors

AndydeCleyre opened this issue 4 years ago · 3 comments

Thanks for this theme!

I don't know if this does now or plans to in the future support color schemes (or live scheme switching, as mdBook does), but looking at the example it's apparent that in some places one of the FG or BG color is forced, while the other is left to the user's browser preference. This yields uncertain and potentially illegible results:

If a FG or BG color is set, please also set the other, so that contrast can be ensured.

To reproduce in Firefox, set preferred FG and BG colors to light on dark:

Answer 1 · 2020-08-06T17:06:36.000Z

Thanks for the report!

I have tried the suggested Firefox setting and found that setting FG and BG on the <body> seems to fix the problem, see #4.

Can you please check if that works for you?

Do I have to add anything else?

I don't know if this does now or plans to in the future support color schemes (or live scheme switching, as mdBook does)

No, currently there is only one fixed color theme.
And yes, it would be great to have multiple color themes in the future.
And yes, it would be great to have live switching.

I've just created #5 to collect a few ideas, please feel free to contribute!

Answer 2 · 2020-08-06T17:15:03.000Z

Thanks! The body looks good on the rendered link in #4. The top bar and nav element FG is light, but that may be intentional.

Answer 3 · 2020-08-06T17:44:54.000Z

Thanks for checking this out!

Thanks! The body looks good on the rendered link in #4. The top bar and nav element FG is light, but that may be intentional.

Yes, the light FG is intentional, it is supposed to get dark on hover.

But this, like everything, is of course open for discussion!