Is the package still being maintained?
justintaft opened this issue · 3 comments
I've created a fork at https://github.com/justintaft/Emacs-langtool/tree/httpserver
- Long running Langtool HTTPServer is used. Grammar checks are now quick without additional JVM spinup.
- Added support to disable grammar highlights based on typefaces (such as markdown code blocks).
- System tests added and run by travis.
Please let me know if I should create a Pull request. I can create a new package if this package is now not maintained.
Great! Please open pull request.
Hey @mhayashi1120. I've been using my forked version for a bit and it's pretty stable. However, there are some breaking changes:
- Users have to install Java 8
- Users have to obtain new version of Language Tool
- Users have to update custom variables.
If my forked version is merged back into your version, then LangTool may break for users who already have it installed. Refactoring the code to support multiple versions of Language Tool will take some effort, but I'm quite busy and won't have time to do so soon. I had a request to add text-to-speech support for blind users, and I think this would be a great addition and time well spent, rather then spending time on backwards compatibility.
How do you think we should proceed? Should a new repository be created with changes, and a new recipe submitted to Melpa? If needed, I can be the maintainer for the new version. Original credit will be given to you, as it's largely your codebase.
Sorry for the late response.
I don't want breaking changes.
And don't mind about your fork and new Melpa recipe.
Thanks for your consideration.