mhergon/AVPlayerViewController-Subtitles

Crash

Closed this issue · 1 comments

Code crashes in case when text is empty

Patch:


---
 Subtitles.swift | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/Subtitles.swift b/Subtitles.swift
index b9541b9..c8d0480 100644
--- a/Subtitles.swift
+++ b/Subtitles.swift
@@ -169,8 +169,15 @@ public extension AVPlayerViewController {
                 scanner.scanDouble(&c)
                 let toTime = (h * 3600.0) + (m * 60.0) + s + (c / 1000.0)

+                let range = NSMakeRange(0, to.range.location + to.range.length + 1)
+                
+                // Check if text is not empty
+                if (group as NSString).length - range.length <= 0 {
+                    continue
+                }
+                
                 // Get text
-                let text = (group as NSString).stringByReplacingCharactersInRange(NSMakeRange(0, to.range.location + to.range.length + 1), withString: "")
+                let text = (group as NSString).stringByReplacingCharactersInRange(range, withString: "")

                 // Create final object
                 let final = NSMutableDictionary()
-- 
2.6.2


Fixed!
Thanks @pwlkania