abi: add functions to encode/decode non-standard types like `uint128` etc.

Question

abi: add functions to encode/decode non-standard types like `uint128` etc.

mhw0 opened this issue a year ago · 26 comments

mhw0 commented a year ago

int eth_abi_mpint(struct eth_abi *abi, mpz_t *mpz)

Answer 1 · 2023-08-21T08:15:42.000Z

int eth_abi_mpint(struct eth_abi *abi, mpz_t *mpz) int eth_rlp_mpint(struct eth_rlp *rlp, mpz_t *mpz)

can u tell me when we will see this feature implmented ?

Answer 2 · 2023-08-21T08:27:50.000Z

As soon as I have free time. It's not hard to implement.

Answer 3 · 2023-08-21T08:33:31.000Z

ok bro. Thanks bro 🙏

Answer 4 · 2023-08-21T18:39:40.000Z

Hi @DerXanRam. Can you pull the dev branch and test the eth_abi_mpint? efd7ee0

Answer 5 · 2023-08-21T18:40:38.000Z

Hi @DerXanRam. Can you pull the dev branch and test the eth_abi_mpint?

Ok..

I'm on it bro 👍

Answer 6 · 2023-08-21T18:54:18.000Z

This the code i am testing with it

void decoder(char *data)
	{
		struct eth_abi abi;
		MP_INT r1, r2;
		uint32_t timee;
		int a;
		// initialize abi struct from encoded abi
		eth_abi_from_hex(&abi, data, -1);
		// decoding happens here
		eth_abi_mpint(&abi,&r1);
		eth_abi_mpint(&abi,&r2);
		eth_abi_uint32(&abi, &timee);
		// free the abi struct
		eth_abi_free(&abi);
		printf("decoded address: %d\n", r1);
		printf("decoded address: %d\n", r2);
		printf("decoded address: %d\n", timee);
	}

and it throughs this error


[{
	"resource": "/usr/include/x86_64-linux-gnu/gmp.h",
	"owner": "cpptools",
	"severity": 8,
	"message": "conflicting declaration of C function ‘std::ostream& operator<<(std::ostream&, mpq_srcptr)’",
	"source": "gcc",
	"startLineNumber": 2286,
	"startColumn": 33,
	"endLineNumber": 2286,
	"endColumn": 33
},{
	"resource": "/usr/include/x86_64-linux-gnu/gmp.h",
	"owner": "cpptools",
	"severity": 8,
	"message": "conflicting declaration of C function ‘std::ostream& operator<<(std::ostream&, mpf_srcptr)’",
	"source": "gcc",
	"startLineNumber": 2287,
	"startColumn": 33,
	"endLineNumber": 2287,
	"endColumn": 33
},{
	"resource": "/usr/include/x86_64-linux-gnu/gmp.h",
	"owner": "cpptools",
	"severity": 8,
	"message": "conflicting declaration of C function ‘std::istream& operator>>(std::istream&, mpq_ptr)’",
	"source": "gcc",
	"startLineNumber": 2289,
	"startColumn": 33,
	"endLineNumber": 2289,
	"endColumn": 33
},{
	"resource": "/usr/include/x86_64-linux-gnu/gmp.h",
	"owner": "cpptools",
	"severity": 8,
	"message": "conflicting declaration of C function ‘std::istream& operator>>(std::istream&, mpf_ptr)’",
	"source": "gcc",
	"startLineNumber": 2290,
	"startColumn": 33,
	"endLineNumber": 2290,
	"endColumn": 33
}]

Answer 7 · 2023-08-21T19:01:19.000Z

Okay, could you open ethc/abi.h and put #include <gmp.h> before #ifdef __cplusplus and test?

Answer 8 · 2023-08-21T19:06:58.000Z

ok wait...

Answer 9 · 2023-08-21T19:11:19.000Z

The previous erros are gone now. But it runs and throws this error
realloc(): invalid pointer
in file abi.c at this line 663
mpz_import(mpz, 32, 1, sizeof(uint8_t), 0, 0, bytes);

Answer 10 · 2023-08-21T19:15:29.000Z

You have to initialize r1 and r2 first (mpz_init(r1) etc).

Answer 11 · 2023-08-21T19:17:01.000Z

To print mpzs, do: gmp_printf("%Zd\n", r1);

Answer 12 · 2023-08-21T19:22:32.000Z

this is the code

void decoder(char *data)
	{
		struct eth_abi abi;
		MP_INT r1, r2;
		mpz_init(r1);
		mpz_init(r2);
		uint32_t timee;
		int a;
		// initialize abi struct from encoded abi
		eth_abi_from_hex(&abi, data, -1);
		// decoding happens here
		eth_abi_mpint(&abi,&r1);
		eth_abi_mpint(&abi,&r2);
		eth_abi_uint32(&abi, &timee);
		// free the abi struct
		eth_abi_free(&abi);
		printf("decoded address: %d\n", r1);
		printf("decoded address: %d\n", r2);
		printf("decoded address: %d\n", timee);
	}

and it throws this error

[{
	"resource": "/home/biruk/Documents/eth/arb+tbot/uniswap.h",
	"owner": "C/C++: IntelliSense",
	"code": "413",
	"severity": 8,
	"message": "no suitable conversion function from \"MP_INT\" to \"mpz_ptr\" exists",
	"source": "C/C++",
	"startLineNumber": 219,
	"startColumn": 12,
	"endLineNumber": 219,
	"endColumn": 14
}]

gmp_printf("%Zd\n", r1);

and is this the only way to print it...what about passing to char* ?

Answer 13 · 2023-08-21T19:26:43.000Z

Try replacing MP_INT with mpz_t

and is this the only way to print it...what about passing to char* ?

gmp_printf is compatible with printf, so, just works: gmp_printf("%Zd %s\n", r1, "test");

Answer 14 · 2023-08-21T19:29:43.000Z

and now this functions parameters are not compatible with mpz_t

eth_abi_mpint(&abi,&r1);
eth_abi_mpint(&abi,&r2);

the error is

[{
	"resource": "/home/biruk/Documents/eth/arb+tbot/uniswap.h",
	"owner": "C/C++: IntelliSense",
	"code": "167",
	"severity": 8,
	"message": "argument of type \"mpz_t *\" is incompatible with parameter of type \"__mpz_struct *\"",
	"source": "C/C++",
	"startLineNumber": 226,
	"startColumn": 22,
	"endLineNumber": 226,
	"endColumn": 22
},{
	"resource": "/home/biruk/Documents/eth/arb+tbot/uniswap.h",
	"owner": "cpptools",
	"severity": 8,
	"message": "cannot convert ‘__mpz_struct (*)[1]’ to ‘__mpz_struct*’",
	"source": "gcc",
	"startLineNumber": 226,
	"startColumn": 36,
	"endLineNumber": 226,
	"endColumn": 36
},{
	"resource": "/home/biruk/Documents/eth/arb+tbot/uniswap.h",
	"owner": "C/C++: IntelliSense",
	"code": "167",
	"severity": 8,
	"message": "argument of type \"mpz_t *\" is incompatible with parameter of type \"__mpz_struct *\"",
	"source": "C/C++",
	"startLineNumber": 227,
	"startColumn": 22,
	"endLineNumber": 227,
	"endColumn": 22
},{
	"resource": "/home/biruk/Documents/eth/arb+tbot/uniswap.h",
	"owner": "cpptools",
	"severity": 8,
	"message": "cannot convert ‘__mpz_struct (*)[1]’ to ‘__mpz_struct*’",
	"source": "gcc",
	"startLineNumber": 227,
	"startColumn": 36,
	"endLineNumber": 227,
	"endColumn": 36
}]

Answer 15 · 2023-08-21T19:32:28.000Z

No, mpz_t is a pointer itself. Just do: eth_abi_mpint(&abi, r1);

Answer 16 · 2023-08-21T19:34:37.000Z

it throws runtim error

/usr/bin/ld: /tmp/ccBXKWZ4.o: undefined reference to symbol '__gmpz_init'
/usr/bin/ld: /lib/x86_64-linux-gnu/libgmp.so.10: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

Answer 17 · 2023-08-21T19:38:04.000Z

Try adding -lgmp to args in tasks.json

Answer 18 · 2023-08-21T19:43:16.000Z

it runned succsussfuly and using printf it gives false decode result and using gmp_printf correct result.

using printf

decoded address: -10256
decoded address: -10240
decoded address: 1690645691

using gmp_printf

6729450845017214267
6777196 
decoded address: 1690645691

Answer 19 · 2023-08-21T19:45:40.000Z

Yes, becuase printf doesn't know about the mpz_t. To print in hex format, do gmp_printf("%Zx\n", r1)

Answer 20 · 2023-08-21T19:45:45.000Z

also i have a question. Can we encode uint256 data types using this new raw data type.... because if i want to send this data back to the RPC function i need a container that holds all of the digits.

Answer 21 · 2023-08-21T19:46:21.000Z

Yes, becuase printf doesn't know about the mpz_t. To print in hex format, do gmp_printf("%Zx\n", r1)

so how to store the data to char* or int for further processing from this data type?

Answer 22 · 2023-08-21T19:50:55.000Z

also i have a question. Can we encode uint256 data types using this new raw data type.... because if i want to send this data back to the RPC function i need a container that holds all of the digits.

Easy:

struct eth_abi abi;
mpz_t mpz;
// 0xfff or 123 or load from uint64 etc..
mpz_init_set_str(mpz, "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff", 0);

eth_abi_init(&abi, ETH_ABI_ENCODE);
eth_abi_mpint(&abi, mpz);
// ...

Here's the gmp manual:
https://gmplib.org/manual/

Answer 23 · 2023-08-21T19:52:42.000Z

also i have a question. Can we encode uint256 data types using this new raw data type.... because if i want to send this data back to the RPC function i need a container that holds all of the digits.

Easy:
struct eth_abi abi;
mpz_t mpz;
// 0xfff or 123 or load from uint64 etc..
mpz_init_set_str(mpz, "0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff", 0);

eth_abi_init(&abi, ETH_ABI_ENCODE);
eth_abi_mpint(&abi, mpz);
// ...
Here's the gmp manual: https://gmplib.org/manual/

ok thanks bro 🙏

Answer 24 · 2023-08-21T20:09:08.000Z

Yes, becuase printf doesn't know about the mpz_t. To print in hex format, do gmp_printf("%Zx\n", r1)

so how to store the data to char* from this data type?

i was trying.... i try to access the struct members and see it. but i lost...... i think i need some hand pls 🙏

Answer 25 · 2023-08-22T03:30:22.000Z

i was trying.... i try to access the struct members and see it. but i lost...... i think i need some hand pls 🙏

Do you want to export mpz_t to char*? It should be like this:

char *str;
gmp_asprintf(&str, "%Zd", r1);
printf("str: %s\n", str);
free(str);

Answer 26 · 2023-08-22T06:38:01.000Z

Closing the issue. Added in efd7ee0