michaeleisel/ZippyJSON

Unknown type name '__uint128_t' on Xcode 12

Closed this issue · 8 comments

Hi, i've got an archiving error on ZippyJSON when archiving my app project, in the simdjson.cpp file :

really_inline value128 full_multiplication(uint64_t value1, uint64_t value2) {
  value128 answer;
#ifdef _MSC_VER
  // todo: this might fail under visual studio for ARM
  answer.low = _umul128(value1, value2, &answer.high);
#else
  __uint128_t r = ((__uint128_t)value1) * value2;
  answer.low = r;
  answer.high = r >> 64;
#endif
  return answer;
}

I have no idea what changed between xcode versions but i had to rollback to using the UIKit regular JSONDecoder.

Same here.
XCode12, tried:

  • With both pod & spm(+pods dependencies)
  • Excluded arm64 arch (new Catalyst compilation)

Had to revert using JSONDecoder for now

Issue may seem more related to https://github.com/michaeleisel/ZippyJSONCFamily dependency

so it was working for you guys on xcode 11, but just not on 12? i can take a look this weekend

i'm unable to reproduce. i've tried:

  • archiving (both armv7 and arm64)
  • building for arm64
  • building for simulator
  • cocoapods and spm

could someone upload a .zip of an xcode project that reproduces it? and @thibauddavid @SimpleApp which OS are you two on?

Tried on a new project, which were compiling fine.
After diving a bit into diffing projects, found out that IPHONEOS_DEPLOYMENT_TARGET was set to 10.0 on pods, which were breaking archiving. Setting it back to 11.0 fixed it :)
Thanks for your time @michaeleisel !

Thanks for your time @michaeleisel , i'm closing this issue if you don't mind.

got it, np. so, how did the change to xcode 12 lead to this issue?

On migrating a pre-xcode12 project, Xcode recommends to migrate this settings to at least 9.0, which I did for all pods without checking if ones needed a higher target, so basically mistake on my side 👍

got it