micheleg/dash-to-dock

Indicator dots overlap app icons in gnome-shell 46.2

Opened this issue · 16 comments

Fedora 40, the white dots that indicate an active app are overlapping the actual icon in any case. Here a screenshot.

white points dock

I have the same problem on Arch Linux with Gnome 46.2

image

Same issue here on 46.2

May be related to previous a issue and fix: #2160 and #2168

I had this problem pre-v90 on any GNOME 46. It's back in GNOME 46.2 + Dash to Dock 92.

I'm also on Fedora 40 using the dnf package for Dash to Dock. 100% scaling on a 2560x1440, 27 inch monitor. Seeing similar behavior on my laptop's much smaller monitor too.

These are my settings:
Screenshot from 2024-05-27 14-57-13

Toggling on "Use built-in theme" definitely improves it.

Screenshot from 2024-05-28 22-06-20

Same issue on Arch, 46.2, with/without custom shell theme.
While toggling "built-in theme" may solve the issue, this is not a solution for those, who want to apply a shell theme

This thing appears after recent gnome-shell updates in fedora 40 or Gnome 46, toggling back indicators from square to dots fixes the issue.

Same issue with Fedora 40. As @akashdiphazra said, changing from default (or, in his case, square) to dots (or any other option) fixed the issue.

You can find this option on the "appearence" page.
image

The "Dots" option is slightly different from "Default".

For example, "Default" does a single dot for applications that you have multiple windows of while "Dots" does multiple dots.

I have the same ui issue

h1ac commented

Changing this option to "Dots" instead of Default fixes it for me!
image

v9lu commented

Same problem here, Fedora 40, Gnome Version 46

Also, I found helpful use Dots, but I found something wrong, and was right - when I compare old screenshot with "Default" and new screenshot with "Dots", the "Default" option looks small and better for me, so fix it pleaseeee :<

Also built-in theme color mismatches with default system dock.

It's a regression/feature in gnome-shell 46.2 so we just need to adapt...

6f215fa55d1ba477ca2c8950344a249742762c36 is the first bad commit
commit 6f215fa55d1ba477ca2c8950344a249742762c36
Author: Sebastian Keller <skeller@gnome.org>
Date:   Sun Mar 17 12:43:03 2024 +0100

    appDisplay: Set running indicator dot offset via CSS
    
    The offset was given as a hardcoded (physical) pixel value and did not
    take scaling into account. This lead to it being shifted closer towards
    the icon as the scale increased.
    
    This now replaces the hardcoded value with a CSS property which
    automatically includes the scale factor.
    
    Further this allows simplifying some calculations that previously were
    trying to counteract the hardcoded offset using margins by using the
    intended offset directly.
    
    With this the dot in the dash is also now placed at exactly the bottom
    of the hover highlight, while previously there was an unintentional 1px
    space.
    
    Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7488
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3245>
    (cherry picked from commit 31997fa2f9f3183d97c22f073e878b308331f288)

 data/theme/gnome-shell-sass/widgets/_app-grid.scss | 4 ++--
 data/theme/gnome-shell-sass/widgets/_dash.scss     | 2 +-
 js/ui/appDisplay.js                                | 7 ++++++-
 3 files changed, 9 insertions(+), 4 deletions(-)

⬆️ Sound like fun, @sergio-costas ? Though I fear that backward compatibility will be a pain.

I'll give it a check...

Is it possible to fix this?

I have to check it, but I think that I have an idea.