michplunkett/ucpd-incident-reporting

Add check for `stored_df` in incident retrieval

Closed this issue · 0 comments

What is?

The application currently errors if there are not any stored incidents.

Traceback (most recent call last):
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/uvicorn/protocols/http/h11_impl.py", line 408, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in __call__
    return await self.app(scope, receive, send)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/fastapi/applications.py", line 1106, in __call__
    await super().__call__(scope, receive, send)
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/starlette/applications.py", line 122, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/starlette/middleware/cors.py", line 83, in __call__
    await self.app(scope, receive, send)
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 20, in __call__
    raise e
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 17, in __call__
    await self.app(scope, receive, send)
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/starlette/routing.py", line 718, in __call__
    await route.handle(scope, receive, send)
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/starlette/routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/starlette/routing.py", line 66, in app
    response = await func(request)
               ^^^^^^^^^^^^^^^^^^^
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/fastapi/routing.py", line 274, in app
    raw_response = await run_endpoint_function(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/fastapi/routing.py", line 193, in run_endpoint_function
    return await run_in_threadpool(dependant.call, **values)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/starlette/concurrency.py", line 41, in run_in_threadpool
    return await anyio.to_thread.run_sync(func, *args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/anyio/to_thread.py", line 33, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
    return await future
           ^^^^^^^^^^^^
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/.venv/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 807, in run
    result = context.run(func, *args)
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/incident_reporting/main.py", line 66, in thirty_day_map
    _, types = client.get_last_30_days_of_incidents(True)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/incident_reporting/external/google_nbd.py", line 211, in get_last_30_days_of_incidents
    df = self._get_incidents_back_x_days(
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/michaelp/Documents/GitHub/ucpd-incident-reporting/incident_reporting/external/google_nbd.py", line 187, in _get_incidents_back_x_days
    .strftime(UCPD_MDY_KEY_DATE_FORMAT)
     ^^^^^^^^