mickael-kerjean/filestash

[Feature Request] semver + docker hub tags

lp35 opened this issue · 1 comments

lp35 commented

Hello all,

I'm sometime a bit confused between filestash version. There is only one tag on docker hub, latest, that prevent users to use the same image over two different system. Only way yo have consistency is to use the long @sha256: trick on the tag, and it's still not possible to make a match with a git tag.

Could you add a more consistentency on versioning/tags over the dockerhub repo? We can discuss of a solution here!

Also it would be great to move everything on https://hub.docker.com/r/mickaelkerjean/filestash because
https://hub.docker.com/r/machines/filestash/ looks might look like a scam!

Thanks

lp35 commented

Hi Mickael, hope you are doing well.

I checked out the code today, because I want to check out the new features you added recently (new frontend), and I'm too afraid of not being able to move back to the previous version (want to keep a stable environment with version of Filestash I carefully tested).

Everything seems to happen in the Jenkinsfile that I assume is part of your internal CI infra.

sh "docker push machines/filestash:latest-amd64"

Short hash should be used in addition of pushing on latest-amd64 using the following command:

git rev-parse --short HEAD

So you need to push 2 times the same image, but docker hub will create a "link" instead of repushing the entire image twice:
"docker push machines/filestash:latest-amd64" "docker push machines/filestash:<SHORT COMMIT HERE>"

I'm also concerned about those lines:

filestash/Jenkinsfile

Lines 9 to 12 in c7d48c9

git(
url: "git@github.com:mickael-kerjean/filestash",
branch: "master"
)

Seems you are manually triggering the pipeline on jenkins for releasing. Maybe you can expose your current git flow? I feel you are directly working in the master branch.

cheer