mickael-kerjean/filestash

[bug] Custom domain for OnlyOffice can't be reached on NPM reverse proxy.

Opened this issue · 0 comments

Description of the bug

If you have a custom domain for onlyoffice and you need to expose the service using a reverse proxy, the domain can't be reached because the index.go file for the onlyoffice plugin is using a relative path instead of the full url + path, causing this error on selfhosted failstash instances.

Step by step instructions to reproduce the bug

Set the custom domain url to ONLYOFFICE_URL=
Map onlyoffice ports to host.
Add a proxy host for the doman, host ip and the exposed port.

Can you replicate that error from the demo?

No, only selfhosted filestash instances with reverse proxy are affected

Observed behavior

Source

filestash couldn't find my api.js file in my onlyoffice server because it was using a relative path and not my full domain name url. By updating line 414 in server/plugin/plg_editor_onlyoffice/index.go to an absolute path that included my domain (hard coded), it started working.

Expected behavior

edit the code to handle external onlyoffice servers if configured/specified in the docker compose file.