mickhansen/dataloader-sequelize

Error: Cannot find module 'bluebird'

wilk opened this issue · 2 comments

wilk commented

Hi,
I've installed dataloader-sequelize@2.3.1 as a dependency of my project but after running the npm prune --production command to remove the devDeps I get the following error:

➜  myproject git:(main) node dist/index.js
internal/modules/cjs/loader.js:888
  throw err;
  ^

Error: Cannot find module 'bluebird'
Require stack:
- /Users/wilk/Projects/myproject/node_modules/dataloader-sequelize/lib/index.js

Then, if I install bluebird as a dependency of the project, it works fine.
Shouldn't be defined inside dataloader-sequelize itself?

mickhansen commented

bluebird used to ship with sequelize i think.
the bluebird dependency should probably be removed from this library, node.js promises are just fine now.

wilk commented

Yep, you're right.
I created a PR for that: #124