microjs/microjs.com

Should use npm 5?

graciano opened this issue · 3 comments

graciano commented

New npm version 5 has a new package-lock.json file that should be commited.
When I ran npm install in my machine with this project I noticed it hasn't this file yet. Since I'm planning on adding something here, should I make another PR creating the new file, or use an older version of npm?

tunnckoCore commented

Hi! ✋

It's not a problem if/to commit it.

Thanks for asking.

  • 👍1
audiolion commented

we should probably have a separate PR for this independent of any added libs

graciano commented

@audiolion Agreed. Since I've already done it locally, I'm sending it in #918. And the addition of my lib will wait until I write a better readme for it. In another PR.