microjs/microjs.com

Some projects in data.js aren't showing up in data-min.js

phred opened this issue · 4 comments

phred commented

I'm not sure the pattern here, but for example here are two libraries in data.js:

Searching for these at microjs.com at the moment turns up no results, nor do they show up in the "framework" category. Looking at data-min.js in the same version, I can't find either project:

https://raw.githubusercontent.com/microjs/microjs.com/a6dc5e4aa203f592a31fcb9c0717a69ddfed6206/data-min.js

They do appear in atom.xml:

I hope I've understood the project structure correctly here (that microjs.com is reading & filtering from data-min.js). Possibly a build issue?

pineapplemachine commented

The build.js script is the one that produces data-min.js and atom.xml from the entries in data.js. It rejects and excludes items where:

  • The source code link is a 404 or otherwise unreachable (Sometimes links break after a project is submitted)
  • The source code link points e.g. to https://github.com/microjs/microjs.com/blob/master/data.js which is an html page instead of to https://raw.githubusercontent.com/microjs/microjs.com/master/data.js which is the raw source code
  • The source code link points to already-minified JS code and not to human-readable unminified code
  • The source code when minified and gzipped is over the size limit. (Sometimes, libraries are under the limit when first submitted but exceed the limit later on.)
  • The source code is really small.
  • Source minification fails - this was happening a lot until the library was updated to use an uglify version that supports ES6+ syntax.
  • The github repository hasn't been updated in several years

There may have been a couple of other criteria that aren't coming to mind right now. If you run build.js it actually prints the reason for every rejection to the console.

HyperApp's source link points to minified JS, this is probably the reason it was rejected

I couldn't say for sure without running the build script myself but it looks like MagJS was very likely rejected due to size

pineapplemachine commented

Closing this issue since I think the question has been adequately answered..?

northeastnerd commented

I take it as contributors we are not supposed to do pull requests on the minimized data-min.js

Can someone please describe how data-min.js is generated in the repository?

pineapplemachine commented

Every so often a maintainer builds a new data-min.js by running the build.js script and then pushes it to the branch that is watched by the website. This way of doing things could probably be changed and improved so that new libraries are added to the site as soon as they're merged, but that's how it is for now