microlinkhq/keyvhq

Expose asyncIterable, keys(), values() and entries()

Jytesh opened this issue · 9 comments

Jytesh commented

Need to do this for all storage adapters

  • Mongo
  • Redis
  • PostgreSQL
  • MySQL
  • SQLite
Jytesh commented

Thoughts on this one?

Kikobeats commented

why this? iterate a large collection will perform very bad 🤔

Jytesh commented

Its probably the most requested feature for keyv, we can maybe expose this and not put it into keyv directly and let the end user get it if needed from store?

Jytesh commented

redis has scan, mongo has cursor, its the sql libs that dont expose some kind of chunked iteration

  • 👍1
Jytesh commented

Is my implementation alright?

Jytesh commented

the iterator can be consumed with a for await loop, and extensions can use the iterator to get keys(), values() and entries(), which should be storage adaptor independent

Jytesh commented

Added key iterator, should add for values and entries as well? and maybe add some tests for those

Jytesh commented

Tests needed to get coverage back to acceptable levels

Kikobeats commented

Thanks for all the effort 🙏